Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix topics with environment #35

Closed
timmc-edx opened this issue Aug 30, 2022 · 0 comments · Fixed by #42
Closed

Prefix topics with environment #35

timmc-edx opened this issue Aug 30, 2022 · 0 comments · Fixed by #42
Assignees
Labels
event-bus Work related to the Event Bus.

Comments

@timmc-edx
Copy link
Contributor

While 2U's deployment will have a separate cluster per environment, that won't be true for all deployers, and it's still worth having a reminder of which environment you're in. So, while an IDA may be configured to produce or consume on topic cert-changed, we'll want the actual Kafka topic to be prod-cert-changed or similar.

A/C:

  • IDAs that use the event bus still just know about the "base" topic (no change)
  • event-bus-kafka reads optional Django setting EVENT_BUS_TOPIC_PREFIX containing a string like "prod" or "staging" that names an environment.
  • If the setting is present, the actual topic used will be f"{prefix}-{base_topic}"; if absent then just base_topic.
@timmc-edx timmc-edx added the event-bus Work related to the Event Bus. label Aug 30, 2022
@timmc-edx timmc-edx moved this to Groomed in Arch-BOM Aug 30, 2022
@timmc-edx timmc-edx moved this from Groomed to Todo in Arch-BOM Aug 30, 2022
@timmc-edx timmc-edx moved this from Todo to Groomed in Arch-BOM Aug 30, 2022
@timmc-edx timmc-edx moved this from Groomed to In Progress in Arch-BOM Sep 7, 2022
@timmc-edx timmc-edx self-assigned this Sep 7, 2022
timmc-edx added a commit that referenced this issue Sep 7, 2022
Closes #35

Also add missing test for consume-loop.
timmc-edx added a commit that referenced this issue Sep 8, 2022
Closes #35

Also add missing test for consume-loop.
timmc-edx added a commit that referenced this issue Sep 8, 2022
Closes #35

Also add missing test for consume-loop.
timmc-edx added a commit that referenced this issue Sep 8, 2022
Closes #35

Also add missing test for consume-loop.
Repository owner moved this from In Progress to Done in Arch-BOM Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event-bus Work related to the Event Bus.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant