fix: don't index courses with a verified upgrade deadline in the past #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveagent57
changed the title
iloveagent57
force-pushed
the
aed/vud-check
branch
3 times, most recently
from
3648e1a
to
08fd234
Compare
adamstankiewicz
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
LGTM, just 1 nit. Likely unrelated to this PR, but our codecov/project is failing in CI due to being 0.05% below our target project coverage of 92%. Not worth fixing in this PR, but wanted to flag anyways 🤷♂️
Related to this comment, totally agree it makes sense to defer on it for now, but I do still think it's worth some consideration in the future.
iloveagent57
force-pushed
the
aed/vud-check
branch
from
08fd234
to
ed79b93
Compare
iloveagent57
force-pushed
the
aed/vud-check
branch
from
ed79b93
to
de633b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update our enterprise-catalog algolia indexing to not include course runs if the verified upgrade has passed. This will make it so that content, with a non-null verified course mode, that is not currently enrollable in the verified track, is not discoverable by learners.
Ticket Link
https://openedx.atlassian.net/browse/ENT-7394