Updated the Dockerfile to switch to python 3.8 #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test these changes locally by building an image. |
|
@jmbowman can you please tag the owning team here. |
jmbowman
reviewed
Aug 31, 2020
Dockerfile
Outdated
| apt-add-repository -y ppa:deadsnakes/ppa && apt-get update && \ | ||
| apt-get upgrade -qy && apt-get install language-pack-en locales git python3.5 python3-pip \ | ||
| python3-pip libmysqlclient-dev libssl-dev python3-dev python3.8-dev python3.8-distutils -qy && \ | ||
| curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py && \ |
There was a problem hiding this comment.
See my question over in the similar xqueue PR: https://github.com/edx/xqueue/pull/778/files#r480147263 . Just want to make sure this is the best pip installation approach before we start using it everywhere.
There was a problem hiding this comment.
@jmbowman we had to make this change because we faced
AttributeError: module 'platform' has no attribute 'linux_distribution'
while building a docker image to verify python 3.8 installation changes in Dockerfile.
I tried using ensurepip and got
/usr/bin/python3.8: No module named ensurepip
while building an image
There was a problem hiding this comment.
Yeah, as I just noted over on the xqueue PR, it doesn't look like there's a much cleaner solution to this until we upgrade to Ubuntu 20.04.
There was a problem hiding this comment.
can you also tag the owing team for review
jmbowman
approved these changes
Sep 1, 2020
|
@bbaker6225 Do you want to review this before we merge it? |
|
Sure I'll give this a quick test |
|
I'm running into the same issue from the license-manager PR on running |
|
No luck unfortunately. Pinning to avoid the setuptools errors might be the way to go |
mraarif
force-pushed
the
BOM-2001
branch
6 times, most recently
from
245e893 to
951ea3d
Compare
|
I was able to build the image and run @bbaker6225 .. let me know if there's something else needed for the review to proceed. |
|
Hi @mraarif , in attempting to rebuild my local enterprise catalog I run into this error: I pulled this branch for enterprise-catalog, ran |
|
Just tried on master and I can confirm that the same provisioning process succeeds using python 3.5 there |
|
@bbaker6225 you should be able to run |
|
I tested the changes by running |
|
Great, I'll give it another run shortly |
|
Thanks for the updates, everything works great except for this error in the worker logs: I can't find many results on google, but one I did find suggested it might be a local only issue with logging to the console. Do you have any ideas? |
|
@bbaker6225 seems like this GitHub issue: celery/celery#5761 has the same error I think |
|
Hm you're right, looks like adding might fix it |
|
I'm changing the worker environment in we'll see if that works |
|
@mraarif yep that worked. I've updated the PR with it and will merge it once tests pass |
irfanuddinahmad
pushed a commit
that referenced
this pull request
Jul 24, 2024
* Updated the Dockerfile to switch to python 3.8 * removed unused curl installation * Add columns:80 as env variable Co-authored-by: Brandon Baker <bbaker@edx.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the Dockerfile to install python 3.8 and pip and use
pipfor python 3.8 to install dependencies.Ticket Link
Link to the associated ticket
BOM-2001
Post-review
Squash commits into discrete sets of changes