-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add LmsApiClient.create_enterprise_admin_user() method #637
Conversation
Thanks for the pull request, @iloveagent57! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
@@ -153,6 +154,40 @@ def get_enterprise_admin_users(self, enterprise_customer_uuid): | |||
|
|||
return results | |||
|
|||
def create_enterprise_admin_user(self, enterprise_customer_uuid, user_email): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[sanity check / consideration] Will we have a need to create multiple enterprise admin users at once during provisioning? Or will we be able to sufficiently get by with only creating 1 enterprise admin user at a time, as suggested here?
Adding support for the multiple known admin users use case is definitely something that could (and probably should) be deferred, though, with the assumption being additional admins could be added self-serve within the Admin Portal in the future.
Just wanted to verify we're confident we don't need to support the multiple enterprise admin users during provisioning use case to start! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same thought - I think we can assume only one for now, and work out details on supporting multiple later. AFAICT, the enterprise pending admin endpoint doesn't support adding multiple admins in a single request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT, the enterprise pending admin endpoint doesn't support adding multiple admins in a single request.
That's my understanding, as well. More reason to deliberately defer on supporting multiple enterprise admins for now.
39af41e
to
56c7f07
Compare
Description:
In service of https://2u-internal.atlassian.net/browse/ENT-9970
Merge checklist:
./manage.py makemigrations
has been runPost merge: