-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initialize enterprise metadata in HandlerContext; complete auto-apply business logic #586
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cd4cd05
feat: initialize enterprise metadata in HandlerContext; integrate APIs
adamstankiewicz d777ed2
chore: quality
adamstankiewicz ee15a10
chore: transform staff_enterprise_customer
adamstankiewicz d65d77e
chore: pr feedback
adamstankiewicz 4ecf7d5
chore: quality
adamstankiewicz f2f8823
chore: test coverage for updated get_enterprise_customer_data
adamstankiewicz 52d343c
chore: pr feedback
adamstankiewicz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initial_response_data
will contain keys likeresults
,next
, etc. right? Is that intended?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, it is intended. Then the subsequent lines below overrides relevant fields like
next
,prev
, etc. to reflect the traversed pagination results being a single page.The primary reason to spread
**initial_response_data
is bring along any other existing pagination fields unrelated to page length, i.e. I believe**initial_response_data
brings alongstart: 0
as well without needing to explicitly define it. Thestart
value from the initial response is unchanged regardless oftraverse_pagination
.