fix: new approach to generate learner_state_count in admin assignments list API; add addtl ordering and filtering support
#324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ordering and filtering support
3 tasks
adamstankiewicz
changed the title
learner_state_counts in admin assignments list API; add addtl ordering and filtering support
adamstankiewicz
changed the title
learner_state_counts in admin assignments list API; add addtl ordering and filtering supportlearner_state_count in admin assignments list API; add addtl ordering and filtering support
iloveagent57
approved these changes
Nov 8, 2023
katrinan029
added a commit
that referenced
this pull request
Nov 13, 2023
fix: refactored code based on reviewer feedback fix: allow non-opaque-keys as content key for allocate requests fix: data migration to delete Actions sans Assignments, and use on_delete=CASCADE (#314) chore: allow optional logging of Django's SQL fix: missing content titles on assignments feat: Try to populate lms_user_id on assignments during creation This is an attempt to cover the case where learners are already logged in at the moment of assignment. This case is a hole left by the work in ENT-7875 which only set out to cover the case where a learner was logged out at the moment of assignment. ENT-7874 feat: Added assignments in credits_available endpoint feat: allowing consumers of the learner content assignment api to filter by email and content title fix: lint error chore: refactored fix: updated failing tests feat: fetch enterprise catalog content metadata, serialize for credits_available assignments ENT-7878 feat: add course_type field to assignment content metadata serializer feat: return `learner_state_counts` as part of the admin assignments list API response (#322) feat: validate requested allocation price feat: link learners during assignment allocation ENT-7778 | Call task to link learners to enterprise customer during allocation, and have that ask add a successful linked action. fix: new approach to generate `learner_state_count` in admin assignments list API; add addtl ordering and filtering support (#324) chore: rebase fix: lint error chore: added test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
content_quantitycan be used with?ordering.learner_state("Status" column) can be filtered by one or more values at a time (e.g.,learner_state=waiting,learner_state=notifying,failed).learner_state_countsis generated to no longer rely on.values('learner_state').annotation(count=Count('uuid', distinct=True)), which seems to be causing the exception seen in the following screenshot locally (not in stage/prod, though?). API now relies onCounterto determine the counts of eachlearner_state. It also now ensuresself.filter_queryset()is called before generating these counts.