Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: data migration to delete Actions sans Assignments, and use on_delete=CASCADE #314
fix: data migration to delete Actions sans Assignments, and use on_delete=CASCADE #314
Changes from all commits
34e70d6
7ed25db
7ccf9f6
61ef724
e12c5a0
e70cffe
aae3d9e
f26fc04
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make quality
was complaining about a duplicate import.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run data migration before altering the
assignments
field below.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This migration is generated with
make migrations
on themain
branch without any code changes... Should it be committed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this missing migration removes the field-level unique constraint that was supposed to be removed as part of #258. I'd say keeping this migration makes the database constraints more closely match the field definition.
Of course now we also know that mysql doesn't actually support the
unique_together
that was supposed to replace the field-level constraint. But maybe that's a problem for a separate ticket.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, hmm, weird. FWIW, MySQL does support
unique_together
, it just doesn't support conditional unique constraints.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the current UNIQUE keys on the table in our production environment:
So the composite key is there, but so is the single-column unique key, which we don't want. So yes, follow Troy's suggestion and let this migration go in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thanks for the sanity check! Will keep this migration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make quality
suggested this pylint ignore comment wasn't necessary.