fix: serializer no longer crashes on bad data #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enterprise_access/apps/api/serializers/subsidy_access_policy.py
Outdated
Show resolved
Hide resolved
pwnage101
force-pushed
the
pwnage101/serializer-less-likely-to-crash
branch
from
1567121 to
efa70a9
Compare
iloveagent57
approved these changes
Oct 25, 2023
This protection against crashing is nice because we use the serializer in django admin, so bad data also crashes django admin.
pwnage101
force-pushed
the
pwnage101/serializer-less-likely-to-crash
branch
from
efa70a9 to
a48182b
Compare
macdiesel
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This protection against crashing is nice because we use the serializer in django admin, so bad data also crashes django admin.