Drop python 3.8 support and other maintenance #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feanil
changed the title
e0d
approved these changes
Jul 24, 2024
| run: sleep 10 && tox | ||
|
|
||
| - name: Run Coverage | ||
| if: matrix.python-version == '3.8' && matrix.toxenv=='django42' | ||
| if: matrix.python-version == '3.12' && matrix.toxenv=='django42' |
There was a problem hiding this comment.
If we support 3.11 should we also run coverage against it?
There was a problem hiding this comment.
We've been running coverage and style only against the latest version which seems to be sufficient and hasn't caused any major issues.
| @@ -25,10 +25,10 @@ validate: clean | |||
| tox | |||
|
|
|||
| test.start_elasticsearch: | |||
| docker-compose up -d | |||
| docker compose up -d | |||
There was a problem hiding this comment.
Seems like the minimum version of docker has changed, do we need a change log message?
There was a problem hiding this comment.
There's no changelog file in this repo but I'll mention it in the release notes when I release the new version.
Without this change we were getting a weird error that the 'install' package could not be found because github action was combining the two lines into a single `pip install setuptools pip install -r requirements/ci.txt` call.
feanil
force-pushed
the
feanil/some_maintenance
branch
from
3adc2ff to
797a862
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make upgradewith Python 3.11