Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirects edge landing page to /dashboard #569

Merged
merged 1 commit into from
Aug 5, 2013
Merged

Conversation

adampalay
Copy link
Contributor

@chrisndodge , @cpennington

I think this could be where the loop occurred

@feanil
Copy link
Contributor

feanil commented Aug 2, 2013

Yep, that seems like it would cause this issue.

@chrisndodge
Copy link
Contributor

Hmm. Looking at the git history it seems like @cpennington did the last edit here, so this must already be in production. Let me take a little bit of a closer look...

@adampalay
Copy link
Contributor Author

@chrisndodge , it was @cpennington 's change, but that was part of the i18n (https://github.com/edx/edx-platform/pull/433/commits) PR that I merged in, so it's not yet in production.

@adampalay
Copy link
Contributor Author

You know what, actually it was my change. I squashed it in to @cpennington 's commit.

@adampalay
Copy link
Contributor Author

@chrisndodge , @cpennington , can you review this?

@chrisndodge
Copy link
Contributor

@adampalay sure. I'm still trying to figure out why this redirect is needed. Do you happen to know what URL this handler is wired to?

@adampalay
Copy link
Contributor Author

@adampalay
Copy link
Contributor Author

It used to redirect to one of the university_profile templates (edge.html), which was removed

@chrisndodge
Copy link
Contributor

I don't know why I'm a bit nervous about this. @cpennington originally set up these landing pages, so I'd feel most comfortable with his eyes on this.

Does this need to be cherry picked into the release tomorrow?

We can proceed, but I'd like to see this up on stage-edge as soon as possible to try it out. Thx.

feanil added a commit that referenced this pull request Aug 5, 2013
redirects edge landing page to /dashboard
@feanil feanil merged commit 2f27f7c into master Aug 5, 2013
@feanil
Copy link
Contributor

feanil commented Aug 5, 2013

@adampalay this change is now on edge-stage and it does not seem to have fixed the problem

chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
e-kolpakov referenced this pull request in open-craft/edx-platform Dec 4, 2015
caesar2164 pushed a commit to caesar2164/edx-platform that referenced this pull request Jan 24, 2017
…-sha-update

Update xblock submit and compare sha Jan 2017
yoann-mroz pushed a commit to weuplearning/edx-platform that referenced this pull request Nov 30, 2020
…le isolated devstacks for same host. (openedx#569)

Updated `README` to document running multiple isolated devstacks on same host

This is the documentation needed for https://github.com/edx/devstack/pull/532
mariajgrimaldi added a commit to eduNEXT/edx-platform that referenced this pull request Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants