-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redirects edge landing page to /dashboard #569
Conversation
Yep, that seems like it would cause this issue. |
Hmm. Looking at the git history it seems like @cpennington did the last edit here, so this must already be in production. Let me take a little bit of a closer look... |
@chrisndodge , it was @cpennington 's change, but that was part of the i18n (https://github.com/edx/edx-platform/pull/433/commits) PR that I merged in, so it's not yet in production. |
You know what, actually it was my change. I squashed it in to @cpennington 's commit. |
@chrisndodge , @cpennington , can you review this? |
@adampalay sure. I'm still trying to figure out why this redirect is needed. Do you happen to know what URL this handler is wired to? |
@chrisndodge the handler is in cms.urls, line 101: https://github.com/edx/edx-platform/blob/master/cms/urls.py?source=cc#L101 |
It used to redirect to one of the university_profile templates (edge.html), which was removed |
I don't know why I'm a bit nervous about this. @cpennington originally set up these landing pages, so I'd feel most comfortable with his eyes on this. Does this need to be cherry picked into the release tomorrow? We can proceed, but I'd like to see this up on stage-edge as soon as possible to try it out. Thx. |
redirects edge landing page to /dashboard
@adampalay this change is now on edge-stage and it does not seem to have fixed the problem |
Refactored wiki cheatsheet code.
Hash Update: Group Project v2
…-sha-update Update xblock submit and compare sha Jan 2017
…le isolated devstacks for same host. (openedx#569) Updated `README` to document running multiple isolated devstacks on same host This is the documentation needed for https://github.com/edx/devstack/pull/532
revert: HA-10
@chrisndodge , @cpennington
I think this could be where the loop occurred