Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: itembank green button #35706

Merged
merged 3 commits into from
Oct 23, 2024
Merged

feat: itembank green button #35706

merged 3 commits into from
Oct 23, 2024
+12 −0

Conversation

DanielVZ96
Copy link
Contributor

@DanielVZ96 DanielVZ96 commented Oct 23, 2024 •
edited
Loading

Description

Adds Problem Bank to the main New Components buttons.

image

Supporting information

Testing instructions

  • Checkout this branch
  • Run tutor dev exec cms npm run watch to build scss changes
  • Go to studio, and create a new unit
  • Assert that you can add a problem bank block from the main component menu.

Deadline

ASAP

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 23, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 23, 2024 •
edited
Loading

Thanks for the pull request, @DanielVZ96!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@kdmccormick
Copy link
Member

Testing...

With contentstore.new_studio_mfe.disable_new_libraries ON:

image

With contentstore.new_studio_mfe.disable_new_libraries OFF:

image

Other than the problembank icon itself, looking good 👍🏻

@DanielVZ96 DanielVZ96 marked this pull request as ready for review October 23, 2024 03:58
@DanielVZ96
Copy link
Contributor Author

@kdmccormick did you try running tutor dev exec cms npm run watch?

DanielVZ96
DanielVZ96 commented Oct 23, 2024
View reviewed changes
cms/djangoapps/contentstore/views/component.py Outdated
Comment on lines 110 to 112
# Libraries v2 content doesn't have an XBlock.
if category == 'library_v2':
if category in ('library_v2', 'itembank'):
return None
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is the case for itembank too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielVZ96 unlike library_v2, itembank is actually a real XBlock tag (the class is ItemBankBlock), so it'd be fine to let this function return the mixed class.

(The only thing that this function's return value is used for is templates, which ItemBankBlock doesn't currently use, so you're change here technically isn't breaking anything. Still, I'd rather you revert this line so that we can minimize the number of special cases.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed with 7127d43

@kdmccormick
Copy link
Member

kdmccormick commented Oct 23, 2024 •
edited
Loading

Ah, right.

I do see the icon now, but it's zoomed in too far.
image

@kdmccormick
Copy link
Member

The new itembank icon png is currently larger (256x256 pixels) than the other green button icon pngs, which might be why it doesn't fit.

Here's it shrunk down to 38x38, which I think looks alright:
image

If you apply this and address #35706 (comment), then I'll be happy to approve & merge this in the morning tomorrow.

pomegranited
pomegranited approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great, thank you @DanielVZ96 !

Note: The problem blank XBlock added by this new button needs #35705 to function properly, but the button looks and works as needed.

  • I tested this using the PR test instructions
  • I read through the code
  • I checked for accessibility issues by using my keyboard to navigate
  • Includes documentation N/A
  • User-facing strings are extracted for translation

@pomegranited
Copy link
Contributor

I believe I've addressed your comments @kdmccormick -- let me know if there's anything else that needs fixing?
And thank you for your help getting this merged tomorrow 🚀

kdmccormick
kdmccormick approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you both!

I'll merge this one right after the ItemBank UI PR.

@kdmccormick kdmccormick merged commit 085b15a into openedx:master Oct 23, 2024
49 checks passed
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@ormsbee ormsbee mentioned this pull request Oct 23, 2024
Merged
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@bradenmacdonald bradenmacdonald deleted the dvz/problem-bank-label branch October 23, 2024 15:48
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomegranited pomegranited pomegranited approved these changes

@kdmccormick kdmccormick kdmccormick approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DanielVZ96 @openedx-webhooks @kdmccormick @pomegranited @edx-pipeline-bot