-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: provide logo url from backend for batch enrollment email #35138
chore: provide logo url from backend for batch enrollment email #35138
Conversation
Thanks for the pull request, @mudassir-hafeez! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
dab5082
to
e4c62bc
Compare
Your branch is behind the base. I've pulled in changes from master as a merge commit which will update your branch and cause the tests to be re-run. |
@e0d, thanks for merging the changes to update my branch and re-run the tests. It seems the commit linting job is failing. I'll fix it and rebase with the upstream master. However, this will require the tests to be re-run. |
ce5bf2a
to
15944df
Compare
@mudassir-hafeez running now. |
15944df
to
d517fc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@mudassir-hafeez 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
…edx#35138) * chore: provide logo url from backend for batch enrollment email
…) (#35378) * chore: provide logo url from backend for batch enrollment email
…edx#35138) * chore: provide logo url from backend for batch enrollment email
…edx#35138) * chore: provide logo url from backend for batch enrollment email
Ticket for internal tracking
https://github.com/mitodl/hq/issues/4923
Description
For the past couple of years, edX has supported a logo URL from the backend for Bulk Email and edX ACE emails. But, this does not have similar support for emails using batch enrollment. Not sure if it is intentional or could have some other reasons but it causes the logo URL to be missed if it needs to be passed from the backend similar to Bulk Email and edX ACE emails.
This pull request addresses the logo not appearing in batch enrollment emails when the logo URL is set in the backend and accessed in the template(or custom theme) similar to how edX Bulk or ACE email use.
Useful information to include:
Supporting information
Testing instructions
LOGO_URL_PNG_FOR_EMAIL
or any of the settings accessed in this code is set.Other information