Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feanil/python311 reqs #34788

Merged
merged 5 commits into from
Jun 11, 2024
Merged

feanil/python311 reqs #34788

merged 5 commits into from
Jun 11, 2024

Conversation

feanil
Copy link
Contributor

@feanil feanil commented May 13, 2024

  • build: Drop testing with Mongo 4.4 and Python 3.8
  • chore: Run make upgarde with Python 3.11
  • build: Add a missing import for importlib_metadata.
  • chore: Run make upgrade
  • fix: Fix an ora2 related test.
  • fix: Update to adjust for new scipy.stats.mode behavior.

Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving under the assumption that you're just splitting up #34780 into smaller PRs

@feanil
Copy link
Contributor Author

feanil commented May 14, 2024

We'll come back to this after Wednesday May 22.

This was being pulled in as a transitive dependency before but it turns
out we need this directly for the usage in
openedx/core/djangoapps/plugins/i18n_api.py

We add it to kernel.in before re-building the requirements files.
Previously the default for the `keepdims` parameter was True, but as of
SciPy 1.11.0 it is false. This is actually the behavior we want here
since we only care about the mode value and not other values.

https://docs.scipy.org/doc/scipy/release/1.11.0-notes.html#expired-deprecations
@feanil feanil marked this pull request as ready for review June 11, 2024 15:30
@feanil feanil merged commit 0b45e99 into master Jun 11, 2024
46 checks passed
@feanil feanil deleted the feanil/python311_reqs branch June 11, 2024 16:59
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

timmc-edx added a commit that referenced this pull request Jun 12, 2024
PR #34788 upgraded some Python dependencies that require Python > 3.8, so
we also need to upgrade the Python version used in the Docker images.
kdmccormick added a commit to kdmccormick/openedx-scorm-xblock that referenced this pull request Jun 25, 2024
1. importlib_resources is a backport of....
2. importlib.resources, a standard library package

Redwood and earlier installed (1).
Starting with the [py3.11 upgrade] we dropped (1) in favor of (2).
To maintain compatibility with both, we use a try-except.

Fixes the error on Tutor Nightly:
ModuleNotFoundError: No module named 'importlib_resources'

[py3.11 upgrade] openedx/edx-platform#34788
ziafazal pushed a commit to overhangio/openedx-scorm-xblock that referenced this pull request Jun 27, 2024
1. importlib_resources is a backport of....
2. importlib.resources, a standard library package

Redwood and earlier installed (1).
Starting with the [py3.11 upgrade] we dropped (1) in favor of (2).
To maintain compatibility with both, we use a try-except.

Fixes the error on Tutor Nightly:
ModuleNotFoundError: No module named 'importlib_resources'

[py3.11 upgrade] openedx/edx-platform#34788
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants