Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Don't require the backports.zoneinfo package for newer python. #34373

Closed
wants to merge 1 commit into from

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Mar 14, 2024

We do this explicitly in bundled.in so that we can build requirements
files that could work to pip install on both the old (3.8) and new
(3.11) versions of python.

This makes it so that the current requirements will all install on python 3.11
without any issues.

We do this explicitly in bundled.in so that we can build requirements
files that could work to `pip install` on both the old (3.8) and new
(3.11) versions of python.
@feanil feanil force-pushed the feanil/pip_install_python_3.11 branch from 8277892 to a57fb4d Compare March 14, 2024 18:34
@feanil
Copy link
Contributor Author

feanil commented Mar 14, 2024

closing in favor of #34374 which includes this change.

The other PR was not actually testing correctly but this should be safe to land regardless since it doesn't break anything and does all us to install requirements on 3.11 to unblock further local testing.

@feanil feanil closed this Mar 14, 2024
@feanil feanil deleted the feanil/pip_install_python_3.11 branch March 14, 2024 19:24
@feanil feanil restored the feanil/pip_install_python_3.11 branch March 14, 2024 19:51
@feanil feanil reopened this Mar 14, 2024
@feanil
Copy link
Contributor Author

feanil commented May 2, 2024

Changes incorporated as a part of #34374

@feanil feanil closed this May 2, 2024
@feanil feanil deleted the feanil/pip_install_python_3.11 branch May 2, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant