chore: unpin django-stubs now that we're on django 4.2 #34237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdmccormick
force-pushed
the
kdmccormick/django-stubs
branch
from
28251ba to
c63815c
Compare
This was referenced Feb 21, 2024
kdmccormick
force-pushed
the
kdmccormick/django-stubs
branch
4 times, most recently
from
0768b19 to
610a864
Compare
kdmccormick
commented
Jun 10, 2024
kdmccormick
force-pushed
the
kdmccormick/django-stubs
branch
from
413b3fb to
1bd9a55
Compare
django-stubs, which provides better type hinting for Django projects, was pinned to an old version (1.16.0) in order to support Django versions <=4. Now that we have upgraded edx-platform to 4.2, we can remove the django-stubs pin, and use the latest version. This will allow us to use type hints more aggressively, especially in the content_libraries app.
kdmccormick
force-pushed
the
kdmccormick/django-stubs
branch
from
1bd9a55 to
b051bc6
Compare
|
Going to open a new PR for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
django-stubs, which provides better type hinting for Django projects, was pinned to an old version (1.16.0) in order to support Django versions <=4.
Now that we have upgraded edx-platform to 4.2, we can remove the django-stubs pin, and use the latest version. This will allow us to use type hints more aggressively, especially in the content_libraries app.
Unpinning django-stubs will create some type errors, which we need to fix before merging this PR.