Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(palm): add JwtRestrictedApplication check to XBlock callback #34048

Conversation

Agrendalath
Copy link
Member

This backports GHSA-qx8m-mqx3-j9fm.

@Agrendalath Agrendalath self-assigned this Jan 12, 2024
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 12, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Agrendalath! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@feanil
Copy link
Contributor

feanil commented Jan 12, 2024

It looks like this failure is consistent though I'm not sure what it has to do with the code that was changed. @Agrendalath I think you'll have to look deeper to figure out what's going on.

@Agrendalath
Copy link
Member Author

@feanil, I cherry-picked the test fix from #33995.

@Agrendalath Agrendalath merged commit e1c9e89 into openedx:open-release/palm.master Jan 16, 2024
41 checks passed
@Agrendalath Agrendalath deleted the agrendalath/xblock-callback-jwt-restricted-application-check-palm branch January 16, 2024 00:39
@openedx-webhooks
Copy link

@Agrendalath 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants