Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added correct image for FB sharing (quince.master) #33785

Open
wants to merge 1 commit into
base: open-release/quince.master
Choose a base branch
from

Conversation

vladislavkeblysh
Copy link

@vladislavkeblysh vladislavkeblysh commented Nov 23, 2023

Issue

This pull request addresses the issue related to missing Open Graph (OG) image metadata in the HTML.

Context

The absence of the <meta property="og:image" /> tag was causing issues with social media sharing and previewing content. This addition ensures that the correct OG image is associated with the page for improved sharing capabilities.

Related Pull Requests

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 23, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 23, 2023

Thanks for the pull request, @vladislavkeblysh!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@vladislavkeblysh vladislavkeblysh marked this pull request as draft November 23, 2023 10:54
@vladislavkeblysh vladislavkeblysh marked this pull request as ready for review November 23, 2023 11:11
@vladislavkeblysh vladislavkeblysh marked this pull request as draft November 23, 2023 11:26
@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Nov 27, 2023
@vladislavkeblysh vladislavkeblysh marked this pull request as ready for review December 29, 2023 13:02
@vladislavkeblysh vladislavkeblysh marked this pull request as draft December 29, 2023 13:02
@vladislavkeblysh vladislavkeblysh self-assigned this Jan 24, 2024
@vladislavkeblysh vladislavkeblysh marked this pull request as ready for review January 24, 2024 09:25
@cmltaWt0 cmltaWt0 added product review PR requires product review before merging and removed product review PR requires product review before merging labels Feb 6, 2024
@mphilbrick211 mphilbrick211 added the product review PR requires product review before merging label Mar 20, 2024
@ihor-romaniuk ihor-romaniuk force-pushed the keblysh/feat/correct-image-for-fb-sharing-quince.master branch from fa3067c to 28a940c Compare August 13, 2024 13:13
@ihor-romaniuk ihor-romaniuk force-pushed the keblysh/feat/correct-image-for-fb-sharing-quince.master branch from 28a940c to 24dd545 Compare September 3, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U product review PR requires product review before merging
Projects
Status: Backlog
Status: Product Review
Development

Successfully merging this pull request may close these issues.

4 participants