-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check masquerade on instructor dashboard tab acess check #33684
fix: check masquerade on instructor dashboard tab acess check #33684
Conversation
Thanks for the pull request, @ArturGaspar! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Sandbox deploy request received. Deployment will start soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: checked that the instructor tab is hidden when masquerading as another student (either by choosing a specific student or a course mode); this matches the behavior of the legacy frontend
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
@ArturGaspar, I want to confirm this part. When masquerading as a "specific student," you still use the "student" role. This works correctly, but I don't understand this part of the PR description. |
@Agrendalath I meant, this PR fixes the case where you masquerade as a role without a specific different user. Updated it to make it more clear. |
Sandbox deployment started. |
Sandbox deployment failed. Check failure logs here https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5492623307.log Please check the settings and requirements and retry deployment by updating the pull request or posting a |
@ArturGaspar 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Sandbox update request received. Deployment will start soon. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
Check also masquerading role to determine if instructor tab is enabled, in order to hide it when a user with access is masquerading as a student role without a specific different user.
Impacts Staff and Instructor users.
Testing instructions
Deadline
None
Other information
Private-Ref: https://tasks.opencraft.com/browse/BB-8087