feat: notifications and preferences will be created in batches #33418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammadadeeltajamul
requested review from
asadazam93,
AhtishamShahid and
saadyousafarbi
| notifications_generated = Notification.objects.bulk_create(notifications) | ||
| audience.append(preference.user_id) | ||
| # send notification to users but use bulk_create | ||
| notification_objects = Notification.objects.bulk_create(notifications, batch_size=batch_size) |
There was a problem hiding this comment.
nit: batch_size has no impact here because user_ids is already batched.
AhtishamShahid
approved these changes
Oct 5, 2023
muhammadadeeltajamul
force-pushed
the
inf-1076
branch
from
d08bb3f
to
778d43b
Compare
muhammadadeeltajamul
force-pushed
the
inf-1076
branch
from
778d43b
to
f37eedc
Compare
asadazam93
approved these changes
Oct 6, 2023
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized creation of notifications and notification preferences
Ticket Link: INF-1076