fix: update discussions blackout dates logic to use discussions confi… #32896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhtishamShahid
requested review from
saadyousafarbi,
awais-ansari,
muhammadadeeltajamul and
asadazam93
asadazam93
approved these changes
Aug 4, 2023
muhammadadeeltajamul
approved these changes
Aug 4, 2023
saadyousafarbi
approved these changes
Aug 4, 2023
|
|
||
| Arguments: | ||
| course: Course to check discussions for | ||
| user: User to check for privileges in course | ||
| """ | ||
| return course.forum_posts_allowed or has_discussion_privileges(user, course.id) | ||
| discussions_config = DiscussionsConfiguration.get(course.id).posting_restrictions |
There was a problem hiding this comment.
Can we rename this to something more specific. Like discussions_posting_restrictions
| self.course.get_discussion_blackout_datetimes() | ||
| ) | ||
|
|
||
| def test_posting_disabled(self): |
There was a problem hiding this comment.
Can we use ddt to group these tests together?
…g data fix: resolved conflicts
AhtishamShahid
force-pushed
the
ahtisham/INF-994
branch
from
e1a6c48
to
7415d40
Compare
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://2u-internal.atlassian.net/browse/INF-994
Description
Use posting_restrictions field from DiscussionsConfiguration mode in the decision for allowing posting in forum, previously only dates were used, which was inconsistent with the use case.