-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FC-0009] feat: Add subsection grading policy mismatch validation #32813
[FC-0009] feat: Add subsection grading policy mismatch validation #32813
Conversation
Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi @yusuf-musleh! Is this ready for review? |
@mphilbrick211 This is part of FC-0009 actually, and I can review it. |
a413c51
to
bd03f13
Compare
@mphilbrick211 @bradenmacdonald yes, its ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks! Nice work. I just had one question but this is good to go.
- I tested this: in Studio, as described
- I read through the code
- I checked for accessibility issues
- Includes documentation: n/a
d37293b
to
88c2885
Compare
Adds validation for the grading assignment and grading policy, showing a warning in Studio if there is a mismatch.
88c2885
to
3d9e6d2
Compare
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Description
This implements openedx/modular-learning#20, it adds validation for the grading assignment and grading policy in subsections, showing a warning in Studio if there is a mismatch.
Testing instructions
Private ref: FAL-3464