-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker multi-arch images push for linux/amd64, linux/arm64 #32686
Docker multi-arch images push for linux/amd64, linux/arm64 #32686
Conversation
@@ -142,30 +142,24 @@ upgrade-package: ## update just one package to the latest usable release | |||
check-types: ## run static type-checking tests | |||
mypy | |||
|
|||
docker_build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to keep the separation between build and push steps? I can envision the need to iterate on the build process locally for development/debugging, without wanting to push the results up to Docker Hub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last remaining concern is "will this slow down production deployments?" It doesn't look like GoCD is checking the status of the "Push Docker Images" workflow after merges to master, but we're not sure why and hence not super confident in that. Maybe you and the team can help figure out if this job is on the critical path for stage and production deployments or not? (It will be eventually when we switch to running edx-platform in Kubernetes, but we have some time to optimize before then.)
env: | ||
DOCKERHUB_PASSWORD: ${{ secrets.DOCKERHUB_PASSWORD }} | ||
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }} | ||
run : make docker_push | ||
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidental trailing whitespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions otherwise we can go ahead and merge the PR. One hour Docker image building time won't affect our normal deployments pipeline for now so we can go ahead with the merge now and create a follow up issue for the optimisation.
d5cdbc7
to
f1eb67c
Compare
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
Description:
In this PR i updated github action for docker multi-arch (linux/amd64, linux/arm64) push
Ticket:
https://github.com/orgs/edx/projects/12/views/1?pane=issue&itemId=28366923