-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: discussion errors in the demo course for Palm #32464
fix: discussion errors in the demo course for Palm #32464
Conversation
Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
d7d5721
to
a9f6670
Compare
@e0d Hi! already merged into the master ;) |
Hi @mariajgrimaldi! Is this something you can merge for us? |
@mphilbrick211: yes! |
This is a backport of a commit to the master branch: openedx/edx-platform#32464 In particular, it will fix many issues that appear when the demo course is imported.
This is a backport of a commit to the master branch: openedx/edx-platform#32464 In particular, it will fix many issues that appear when the demo course is imported.
This backport will be cherry-picked in Tutor: overhangio/tutor#881 |
This is a backport of a commit to the master branch: openedx/edx-platform#32464 In particular, it will fix many issues that appear when the demo course is imported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patience! I tested this on my palm environment, and it worked like a charm! Thank you so much 🚀
085987e
into
openedx:open-release/palm.master
Discussion: - openedx/wg-build-test-release#276 Co-authored-by: Edward Zarecor <ezarecor@tcril.org>
This is a backport of a commit to the master branch: openedx/edx-platform#32464 In particular, it will fix many issues that appear when the demo course is imported.
This is a backport from the master branch
Description
This is a bug fix that was taken from the discussion.
This issue is possible for the Demo course as well as other courses.
To reproduce this bug, you need the following conditions:
This fix eliminates the possibility of displaying the Discussion block if the environment variable ENABLE_DISCUSSION_SERVICE is set to False: