Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: default grade designations configurable from settings #32406
feat: default grade designations configurable from settings #32406
Changes from all commits
218a010
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaustavb12 could be a dumb question, but is there a possibility of
this.GRADES
being undefined if this line is invoked?Eg. if options.gradeDesignations == 0 then these lines will trigger an error:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keithgg
Great question.
We already have a default value of
this.GRADES
, therefore I feel the chances ofthis.GRADES
being undefined is slim.The place which is most likely to break with an erroneous value of
options.gradeDesignations
is the length check in thesetupGradeDesignations
method. Although, for most scenarios, such as passing an intereger, strings, empty arrays etc., this seems to be handled elegently by the browser and nothing breaks. Only explicitly passingNone/null
seems to break this.To mitigate that, I have now added a check to verify that
gradeDesignations
is infact a valid array. This seems to handle those edge cases I mentioned above.