feat!: use mongo timestamp when sending course_catalog_info_changed events to the event bus #31698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When producing the catalog-info-changed signal, we now get the timestamp of the change from modulestore, rather than relying on the current time at the time of the event send. BREAKING CHANGE: This will adjust the meaning of the time metadata for new catalog-info-changed events.
…ithub.com/edx/edx-platform into robrap/use-db-timestamp-for-catalog-event
robrap
approved these changes
Feb 2, 2023
robrap
reviewed
Feb 2, 2023
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
1 similar comment
|
EdX Release Notice: This PR has been deployed to the production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: openedx/openedx-events#159
Use mongo's subtree_edited_on timestamp instead of default producer time when sending course_catalog_info_changed events to the event bus. This will give us a better idea of what time the actual change took place, rather than when it made it to the producer.
Tested locally by putting a sleep in between generating the course_catalog_info_signal data and actually sending it. Confirmed the ce_time header refers to the time the course was actually changed.