fix: fixed the pylint violations causing quality failures #27934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaisdar001
approved these changes
Jun 11, 2021
|
Your PR has finished running tests. There were no failures. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
blarghmatey
pushed a commit
to mitodl/edx-platform
that referenced
this pull request
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR merged today caused the
pylintviolations on the master which is causing the quality builds to fail. Here is an example failed build showing the violation occuring on the master builds.Possible reason for the error
The PR has the old quality check output on it which shows like the quality build was ran on the PR before the
diff-qualitychanges had been merged in the master and hence that caused the error on master branch later on but it'll need to be investigated further.Fix
This PR fixes these
pylintviolations to allow the quality builds to pass.