Prevent errors for escalation email if proctoring is disabled #27166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangsto
force-pushed
the
alangsto/no_error_if_proctoring_disabled
branch
2 times, most recently
from
367cdda to
47d30a1
Compare
alangsto
changed the title
zacharis278
approved these changes
Mar 29, 2021
alangsto
force-pushed
the
alangsto/no_error_if_proctoring_disabled
branch
3 times, most recently
from
1449f12 to
8c761ae
Compare
fix for quality fix for python tests fixed bug that prevented updating fields fixed tests fixed other tests
alangsto
force-pushed
the
alangsto/no_error_if_proctoring_disabled
branch
from
8c761ae to
50842de
Compare
|
Your PR has finished running tests. There were no failures. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MST-643 - Allow proctoring settings to be validated if the proctoring escalation email is missing but proctoring is disabled.
This PR is also related to a PR on frontend-app-course-authoring, which removes validation on the frontend for this specific case.