Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: "Invalid type for parameter ContentType" error on js upload #25957

Merged
merged 1 commit into from
Feb 1, 2021
Merged

fix: "Invalid type for parameter ContentType" error on js upload #25957

merged 1 commit into from
Feb 1, 2021

Conversation

regisb
Copy link
Contributor

@regisb regisb commented Dec 30, 2020

We are affected by this issue:
jazzband/django-pipeline#297 (comment)

In particular, this occurs when trying to upload js assets to s3, such
as with the Scorm xblock:
overhangio/openedx-scorm-xblock#16

This issue is resolved by upgrading django-pipeline to 2.0.3+, as the
fix was introduced here:
jazzband/django-pipeline#715

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Dec 30, 2020
@openedx-webhooks
Copy link

Thanks for the pull request, @regisb! I've created OSPR-5319 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

regisb referenced this pull request in overhangio/tutor Dec 30, 2020
@regisb
Fix "Invalid type for parameter ContentType" error in scorm xblock
3bdc038 
Close overhangio/openedx-scorm-xblock#16
See upstream PR: https://github.com/edx/edx-platform/pull/25957
See discussion: https://discuss.overhang.io/t/issue-with-scorm/1126
@natabene
Copy link
Contributor

natabene commented Jan 4, 2021

@regisb Thank you for your contribution. Looks like this is ready for our review, correct?

@regisb
Copy link
Contributor Author

regisb commented Jan 4, 2021

Thanks @natabene! Yes, this is ready for review.

jmbowman
jmbowman approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@jmbowman jmbowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing; looks fine to me once it's rebased. We'll be going through shortly and dropping the rest of the constraints that were only there for Python 3.5 support, just hadn't gotten to it yet.

@regisb
fix: "Invalid type for parameter ContentType" error on js upload
c656ce0 
We are affected by this issue:
jazzband/django-pipeline#297 (comment)

In particular, this occurs when trying to upload js assets to s3, such
as with the Scorm xblock:
overhangio/openedx-scorm-xblock#16

This issue is resolved by upgrading django-pipeline to 2.0.3+, as the
fix was introduced here:
jazzband/django-pipeline#715
@regisb
Copy link
Contributor Author

regisb commented Jan 29, 2021

rebased!

@regisb regisb force-pushed the regisb/upgrade-django-pipeline branch from a4e732a to c656ce0 Compare January 29, 2021 10:18
@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@jmbowman jmbowman merged commit d89868b into openedx:master Feb 1, 2021
@openedx-webhooks
Copy link

@regisb 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

@regisb regisb deleted the regisb/upgrade-django-pipeline branch February 1, 2021 14:27
@regisb
Copy link
Contributor Author

regisb commented Feb 1, 2021

Thanks @jmbowman :)

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

OmarIthawi referenced this pull request in appsembler/edx-platform Aug 19, 2021
@OmarIthawi
RED-2381: fix: "Invalid type for parameter ContentType" error on js u…
3c18322 
…pload

This fix is useless and should be reverted once https://github.com/edx/edx-platform/pull/25957
is merged into the Tahoe branch when Maple is used.
@OmarIthawi OmarIthawi mentioned this pull request Aug 19, 2021
Merged
johanseto pushed a commit to eduNEXT/edx-platform that referenced this pull request Jun 16, 2022
@regisb @johanseto
fix: "Invalid type for parameter ContentType" error on js upload (ope…
6150b03 
…nedx#25957)

We are affected by this issue:
jazzband/django-pipeline#297 (comment)

In particular, this occurs when trying to upload js assets to s3, such
as with the Scorm xblock:
overhangio/openedx-scorm-xblock#16

This issue is resolved by upgrading django-pipeline to 2.0.3+, as the
fix was introduced here:
jazzband/django-pipeline#715

(cherry picked from commit d89868b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmbowman jmbowman jmbowman approved these changes

Assignees
No one assigned
Labels
merged open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@regisb @openedx-webhooks @natabene @edx-status-bot @edx-pipeline-bot @jmbowman