chore: address lint warnings

openedx · Oct 7, 2024 · 3de76a5 · 3de76a5
1 parent 4aaf64c
commit 3de76a5
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/openedx/core/djangoapps/content_libraries/library_context.py b/openedx/core/djangoapps/content_libraries/library_context.py
@@ -46,9 +46,9 @@ def can_edit_block(self, user: UserType, usage_key: UsageKeyV2) -> bool:
             return True
         except PermissionDenied:
             return False
-        except api.ContentLibraryNotFound:
+        except api.ContentLibraryNotFound as exc:
             # A 404 is probably what you want in this case, not a 500 error, so do that by default.
-            raise NotFound(f"Content Library '{usage_key.lib_key}' does not exist")
+            raise NotFound(f"Content Library '{usage_key.lib_key}' does not exist") from exc
 
     def can_view_block_for_editing(self, user: UserType, usage_key: UsageKeyV2) -> bool:
         """
@@ -64,9 +64,9 @@ def can_view_block_for_editing(self, user: UserType, usage_key: UsageKeyV2) -> b
             return True
         except PermissionDenied:
             return False
-        except api.ContentLibraryNotFound:
+        except api.ContentLibraryNotFound as exc:
             # A 404 is probably what you want in this case, not a 500 error, so do that by default.
-            raise NotFound(f"Content Library '{usage_key.lib_key}' does not exist")
+            raise NotFound(f"Content Library '{usage_key.lib_key}' does not exist") from exc
 
     def can_view_block(self, user: UserType, usage_key: UsageKeyV2) -> bool:
         """
@@ -84,9 +84,9 @@ def can_view_block(self, user: UserType, usage_key: UsageKeyV2) -> bool:
             return True
         except PermissionDenied:
             return False
-        except api.ContentLibraryNotFound:
+        except api.ContentLibraryNotFound as exc:
             # A 404 is probably what you want in this case, not a 500 error, so do that by default.
-            raise NotFound(f"Content Library '{usage_key.lib_key}' does not exist")
+            raise NotFound(f"Content Library '{usage_key.lib_key}' does not exist") from exc
 
     def block_exists(self, usage_key: LibraryUsageLocatorV2):
         """

diff --git a/openedx/core/djangoapps/content_libraries/tests/test_content_libraries.py b/openedx/core/djangoapps/content_libraries/tests/test_content_libraries.py
@@ -508,7 +508,7 @@ def test_library_not_found(self):
         response = self.client.get(URL_BLOCK_METADATA_URL.format(block_key=valid_not_found_key))
         self.assertEqual(response.status_code, 404)
         self.assertEqual(response.json(), {
-            'detail': f"Content Library 'lib:valid:key' does not exist",
+            'detail': "Content Library 'lib:valid:key' does not exist",
         })
 
     def test_block_not_found(self):

diff --git a/openedx/core/djangoapps/xblock/api.py b/openedx/core/djangoapps/xblock/api.py
@@ -125,9 +125,9 @@ def load_block(usage_key, user, *, check_permission: CheckPerm | None = CheckPer
 
     try:
         return runtime.get_block(usage_key)
-    except NoSuchUsage:
+    except NoSuchUsage as exc:
         # Convert NoSuchUsage to NotFound so we do the right thing (404 not 500) by default.
-        raise NotFound(f"The component '{usage_key}' does not exist.")
+        raise NotFound(f"The component '{usage_key}' does not exist.") from exc
 
 
 def get_block_metadata(block, includes=()):