Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade Python requirements #408

Conversation

edx-requirements-bot
Copy link
Contributor

Python requirements update. Please review the changelogs for the upgraded packages.

Deleted obsolete pull_requests:
#407

@felipemontoya
Copy link
Member

felipemontoya commented Sep 4, 2024

This is failing in Python 3.8 because of edx-lint dropping support for 3.8.

The error message is:

quality: commands[1]> pylint --rcfile=pylintrc organizations
Traceback (most recent call last):
  File "/home/runner/work/edx-organizations/edx-organizations/.tox/quality/bin/pylint", line 8, in <module>
    sys.exit(run_pylint())
  File "/home/runner/work/edx-organizations/edx-organizations/.tox/quality/lib/python3.8/site-packages/pylint/__init__.py", line 34, in run_pylint
    PylintRun(argv or sys.argv[1:])
  File "/home/runner/work/edx-organizations/edx-organizations/.tox/quality/lib/python3.8/site-packages/pylint/lint/run.py", line 162, in __init__
    args = _config_initialization(
  File "/home/runner/work/edx-organizations/edx-organizations/.tox/quality/lib/python3.8/site-packages/pylint/config/config_initialization.py", line 61, in _config_initialization
    linter.load_plugin_modules(utils._splitstrip(config_data["load-plugins"]))
  File "/home/runner/work/edx-organizations/edx-organizations/.tox/quality/lib/python3.8/site-packages/pylint/lint/pylinter.py", line 380, in load_plugin_modules
    module.register(self)
  File "/home/runner/work/edx-organizations/edx-organizations/.tox/quality/lib/python3.8/site-packages/edx_lint/pylint/plugin.py", line 38, in register
    mod.register_checkers(linter)
  File "/home/runner/work/edx-organizations/edx-organizations/.tox/quality/lib/python3.8/site-packages/edx_lint/pylint/annotations_check.py", line 22, in register_checkers
    linter.register_checker(CodeAnnotationChecker(linter))
  File "/home/runner/work/edx-organizations/edx-organizations/.tox/quality/lib/python3.8/site-packages/edx_lint/pylint/annotations_check.py", line 257, in __init__
    importlib.resources.files("code_annotations").joinpath(
AttributeError: module 'importlib.resources' has no attribute 'files'
quality: exit 1 (0.38 seconds) /home/runner/work/edx-organizations/edx-organizations> pylint --rcfile=pylintrc organizations pid=2100

Which comes from: https://github.com/openedx/edx-lint/pull/445/files#diff-8f87fc90d4a6cacc1964026066dad39c6e93ae895a7edeeb3adfbedf9939e3b9R257

@edx-requirements-bot
Copy link
Contributor Author

Closing obsolete PR.

@edx-requirements-bot edx-requirements-bot deleted the repo-tools/upgrade-python-requirements-dee1f11 branch September 9, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants