Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jkantor/submission check #2162

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Jkantor/submission check #2162

merged 2 commits into from
Jan 16, 2024

Conversation

jansenk
Copy link
Contributor

@jansenk jansenk commented Jan 16, 2024

Don't check for equality in the client and server uuids when the client doesn't provide one

@jansenk jansenk requested a review from a team as a code owner January 16, 2024 15:51
@jansenk jansenk force-pushed the jkantor/submission-check branch from f705276 to 9ecadc4 Compare January 16, 2024 15:51
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3bab90) 94.94% compared to head (9ecadc4) 94.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2162   +/-   ##
=======================================
  Coverage   94.94%   94.95%           
=======================================
  Files         191      191           
  Lines       20584    20617   +33     
  Branches     1863     1864    +1     
=======================================
+ Hits        19544    19577   +33     
  Misses        777      777           
  Partials      263      263           
Flag Coverage Δ
unittests 94.95% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@jansenk jansenk merged commit dc53d20 into master Jan 16, 2024
7 checks passed
@jansenk jansenk deleted the jkantor/submission-check branch January 16, 2024 15:58
BryanttV pushed a commit to eduNEXT/edx-ora2 that referenced this pull request Feb 6, 2024
* fix: skip check when uuid not passed

* chore: version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants