Merge pull request #2231 from openedx/bilalqamar/node-v18-upgrade

feat: upgrade node v18
openedx · Oct 21, 2024 · a352fd5 · a352fd5
2 parents a8d0136 + e9fac04
commit a352fd5
Show file tree

Hide file tree

Showing 6 changed files with 12,740 additions and 11,681 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -16,7 +16,7 @@ jobs:
       matrix:
         os: [ubuntu-latest]
         python-version: ['3.8', '3.11']
-        node-version: [16]
+        node-version: [18]
         toxenv: [quality, js, django42]
 
     steps:

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-16
+18
diff --git a/openassessment/xblock/static/js/src/lms/components/WaitingStepContent.jsx b/openassessment/xblock/static/js/src/lms/components/WaitingStepContent.jsx
@@ -66,6 +66,7 @@ WaitingStepContent.propTypes = {
     must_grade: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
     waiting_count: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
     overwritten_count: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
+    // eslint-disable-next-line react/forbid-prop-types
     student_data: PropTypes.arrayOf(PropTypes.object),
   }).isRequired,
   refreshData: PropTypes.func,

diff --git a/openassessment/xblock/static/js/src/lms/components/WaitingStepList.jsx b/openassessment/xblock/static/js/src/lms/components/WaitingStepList.jsx
@@ -87,6 +87,7 @@ const WaitingStepList = ({
 };
 
 WaitingStepList.propTypes = {
+  // eslint-disable-next-line react/forbid-prop-types
   studentList: PropTypes.arrayOf(PropTypes.object).isRequired,
   refreshData: PropTypes.func,
   findLearner: PropTypes.func,