Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase commitlint header-max-length for squashed PR numbers #487

Conversation

brian-smith-tcril
Copy link
Contributor

Description:

The default commitlint header-max-length (from config-conventional) is 100 characters. This is generally not a problem, but in situations where a PR is squashed the default GH web UI behavior appends (#X[...]X) to the commit message header. This can cause commits that have landed to fail commitlint.

This PR just gives us a little wiggle room for those scenarios.

Merge checklist:

  • All reviewers approved
  • CI build is green
  • If adding new checks, followed how_tos/0001-adding-new-checks.rst
  • Changelog record added (if needed)
  • Documentation updated (not only docstrings) (if needed)
  • Commits are squashed

@brian-smith-tcril brian-smith-tcril merged commit 6ee3ab3 into openedx:master Feb 19, 2025
4 checks passed
@brian-smith-tcril brian-smith-tcril deleted the commitlint-header-max-length branch February 19, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants