Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update cornerstone client to store API calls in DB #1994

Merged
merged 17 commits into from
Jan 31, 2024

Conversation

hamzawaleed01
Copy link
Member

@hamzawaleed01 hamzawaleed01 commented Jan 22, 2024

…in db

Merge checklist:

  • Any new requirements are in the right place (do not manually modify the requirements/*.txt files)
    • base.in if needed in production but edx-platform doesn't install it
    • test-master.in if edx-platform pins it, with a matching version
    • make upgrade && make requirements have been run to regenerate requirements
  • make static has been run to update webpack bundling if any static content was updated
  • ./manage.py makemigrations has been run
    • Checkout the Database Migration Confluence page for helpful tips on creating migrations.
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.
    • This should be run from either a venv with all the lms/edx-enterprise requirements installed or if you checked out edx-enterprise into the src directory used by lms, you can run this command through an lms shell.
      • It would be ./manage.py lms makemigrations in the shell.
  • Version bumped
  • Changelog record added
  • Translations updated (see docs/internationalization.rst but also this isn't blocking for merge atm)

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in GitHub Actions, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in edx-platform to upgrade dependencies (including edx-enterprise)
    • This must be done after the version is visible in PyPi as make upgrade in edx-platform will look for the latest version in PyPi.
    • Note: the edx-enterprise constraint in edx-platform must also be bumped to the latest version in PyPi.

@hamzawaleed01 hamzawaleed01 marked this pull request as draft January 22, 2024 13:10
@hamzawaleed01 hamzawaleed01 force-pushed the hamza/ENT-8276-record-corner-stone-api-calls branch from fe9a533 to 95071ab Compare January 23, 2024 11:03
@hamzawaleed01 hamzawaleed01 force-pushed the hamza/ENT-8276-record-corner-stone-api-calls branch 7 times, most recently from f8beba0 to abaedbd Compare January 25, 2024 09:33
@hamzawaleed01 hamzawaleed01 force-pushed the hamza/ENT-8276-record-corner-stone-api-calls branch from abaedbd to b5d6b33 Compare January 25, 2024 09:42
@hamzawaleed01 hamzawaleed01 force-pushed the hamza/ENT-8276-record-corner-stone-api-calls branch from a839059 to 4191000 Compare January 25, 2024 10:37
@hamzawaleed01 hamzawaleed01 marked this pull request as ready for review January 25, 2024 10:57
@hamzawaleed01 hamzawaleed01 changed the title feat: update cornerstone client to store cornerstone API calls … feat: update cornerstone client to store API calls in DB Jan 25, 2024
@hamzawaleed01 hamzawaleed01 force-pushed the hamza/ENT-8276-record-corner-stone-api-calls branch from 46dafdb to a161565 Compare January 29, 2024 09:11
@hamzawaleed01 hamzawaleed01 force-pushed the hamza/ENT-8276-record-corner-stone-api-calls branch 2 times, most recently from 1dfb169 to 4af246d Compare January 30, 2024 09:13
@hamzawaleed01 hamzawaleed01 force-pushed the hamza/ENT-8276-record-corner-stone-api-calls branch from 4af246d to d5bd99d Compare January 30, 2024 09:47
Copy link
Member

@sameenfatima78 sameenfatima78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question but looks good otherwise

@hamzawaleed01 hamzawaleed01 force-pushed the hamza/ENT-8276-record-corner-stone-api-calls branch from ee80385 to 60d60bd Compare January 31, 2024 10:03
@hamzawaleed01 hamzawaleed01 merged commit 5a4d283 into master Jan 31, 2024
9 checks passed
@hamzawaleed01 hamzawaleed01 deleted the hamza/ENT-8276-record-corner-stone-api-calls branch January 31, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants