-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENT-7950] - Post skills metadata for Degreed2 #1969
[ENT-7950] - Post skills metadata for Degreed2 #1969
Conversation
64a5075
to
0017d64
Compare
…to hamza/ENT-7950-degreed-post-skills-metadata
0017d64
to
cd4cb15
Compare
4378995
to
1f95958
Compare
1f95958
to
1ce0a43
Compare
…to hamza/ENT-7950-degreed-post-skills-metadata
LOGGER.info( | ||
generate_formatted_log( | ||
self.enterprise_configuration.channel_code(), | ||
self.enterprise_configuration.enterprise_customer.uuid, | ||
None, | ||
None, | ||
f'[Degreed2Client] metadata: {metadata}' | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This log may not be providing us any useful info that isn't already being logged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah you're right! I just added it temporarily to see the exact response in production once to test things. if everything works as expected then I'll remove this log.
) | ||
) | ||
# 2. Transmit to degreed | ||
skills = metadata['skill_names'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: It's always safe to use metadata.get('skill_names', [])
just as a caution. metadata['skill_names']
will throw a KeyError
in case we return empty dict.
cfbe2e1
to
a18241c
Compare
a18241c
to
80225d0
Compare
54a0801
to
2b22668
Compare
Merge checklist:
requirements/*.txt
files)base.in
if needed in production but edx-platform doesn't install ittest-master.in
if edx-platform pins it, with a matching versionmake upgrade && make requirements
have been run to regenerate requirementsmake static
has been run to update webpack bundling if any static content was updated./manage.py makemigrations
has been run./manage.py lms makemigrations
in the shell.Post merge:
(so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
make upgrade
in edx-platform will look for the latest version in PyPi.