Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENT-7950] - Post skills metadata for Degreed2 #1969

Merged
merged 7 commits into from
Dec 20, 2023

Conversation

hamzawaleed01
Copy link
Member

Merge checklist:

  • Any new requirements are in the right place (do not manually modify the requirements/*.txt files)
    • base.in if needed in production but edx-platform doesn't install it
    • test-master.in if edx-platform pins it, with a matching version
    • make upgrade && make requirements have been run to regenerate requirements
  • make static has been run to update webpack bundling if any static content was updated
  • ./manage.py makemigrations has been run
    • Checkout the Database Migration Confluence page for helpful tips on creating migrations.
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.
    • This should be run from either a venv with all the lms/edx-enterprise requirements installed or if you checked out edx-enterprise into the src directory used by lms, you can run this command through an lms shell.
      • It would be ./manage.py lms makemigrations in the shell.
  • Version bumped
  • Changelog record added
  • Translations updated (see docs/internationalization.rst but also this isn't blocking for merge atm)

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in GitHub Actions, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in edx-platform to upgrade dependencies (including edx-enterprise)
    • This must be done after the version is visible in PyPi as make upgrade in edx-platform will look for the latest version in PyPi.
    • Note: the edx-enterprise constraint in edx-platform must also be bumped to the latest version in PyPi.

@hamzawaleed01 hamzawaleed01 force-pushed the hamza/ENT-7950-degreed-post-skills-metadata branch 2 times, most recently from 64a5075 to 0017d64 Compare December 18, 2023 10:00
…to hamza/ENT-7950-degreed-post-skills-metadata
@hamzawaleed01 hamzawaleed01 force-pushed the hamza/ENT-7950-degreed-post-skills-metadata branch from 0017d64 to cd4cb15 Compare December 18, 2023 10:04
@hamzawaleed01 hamzawaleed01 force-pushed the hamza/ENT-7950-degreed-post-skills-metadata branch from 4378995 to 1f95958 Compare December 19, 2023 10:09
@hamzawaleed01 hamzawaleed01 force-pushed the hamza/ENT-7950-degreed-post-skills-metadata branch from 1f95958 to 1ce0a43 Compare December 19, 2023 10:15
…to hamza/ENT-7950-degreed-post-skills-metadata
enterprise/api_client/enterprise_catalog.py Outdated Show resolved Hide resolved
enterprise/api_client/enterprise_catalog.py Show resolved Hide resolved
integrated_channels/degreed2/client.py Outdated Show resolved Hide resolved
integrated_channels/degreed2/client.py Outdated Show resolved Hide resolved
Comment on lines 287 to 295
LOGGER.info(
generate_formatted_log(
self.enterprise_configuration.channel_code(),
self.enterprise_configuration.enterprise_customer.uuid,
None,
None,
f'[Degreed2Client] metadata: {metadata}'
)
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This log may not be providing us any useful info that isn't already being logged.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah you're right! I just added it temporarily to see the exact response in production once to test things. if everything works as expected then I'll remove this log.

integrated_channels/degreed2/client.py Outdated Show resolved Hide resolved
)
)
# 2. Transmit to degreed
skills = metadata['skill_names']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It's always safe to use metadata.get('skill_names', []) just as a caution. metadata['skill_names'] will throw a KeyError in case we return empty dict.

integrated_channels/degreed2/client.py Outdated Show resolved Hide resolved
integrated_channels/degreed2/client.py Outdated Show resolved Hide resolved
@hamzawaleed01 hamzawaleed01 force-pushed the hamza/ENT-7950-degreed-post-skills-metadata branch from cfbe2e1 to a18241c Compare December 20, 2023 06:49
@hamzawaleed01 hamzawaleed01 force-pushed the hamza/ENT-7950-degreed-post-skills-metadata branch from a18241c to 80225d0 Compare December 20, 2023 06:59
@hamzawaleed01 hamzawaleed01 force-pushed the hamza/ENT-7950-degreed-post-skills-metadata branch from 54a0801 to 2b22668 Compare December 20, 2023 11:00
@hamzawaleed01 hamzawaleed01 merged commit f2ee353 into master Dec 20, 2023
7 checks passed
@hamzawaleed01 hamzawaleed01 deleted the hamza/ENT-7950-degreed-post-skills-metadata branch December 20, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants