Skip to content

Commit

Permalink
Removing decrypted client secret in sap configuration from code (#2228)
Browse files Browse the repository at this point in the history
* feat: removed char field decrypted_secret from code
  • Loading branch information
MueezKhan246 authored Sep 5, 2024
1 parent d880ce8 commit d255e40
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 16 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ Unreleased
----------
* nothing unreleased

[4.25.1]
----------
* feat: removed char field decrypted_secret references

[4.25.0]
----------
* feat: emit learner credit unenrollment event
Expand Down
2 changes: 1 addition & 1 deletion enterprise/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
Your project description goes here.
"""

__version__ = "4.25.0"
__version__ = "4.25.1"
2 changes: 0 additions & 2 deletions enterprise/signals.py
Original file line number Diff line number Diff line change
Expand Up @@ -473,5 +473,3 @@ def update_decrypted_credentials(sender, instance, **kwargs): # pylint: disa
"""
if instance.key != instance.decrypted_key:
instance.decrypted_key = instance.key
if instance.secret != instance.decrypted_secret:
instance.decrypted_secret = instance.secret
1 change: 0 additions & 1 deletion integrated_channels/sap_success_factors/admin/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ class SAPSuccessFactorsEnterpriseCustomerConfigurationAdmin(DjangoObjectActions,
"key",
"decrypted_key",
"secret",
"decrypted_secret",
"sapsf_user_id",
"user_type",
"has_access_token",
Expand Down
12 changes: 0 additions & 12 deletions integrated_channels/sap_success_factors/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,18 +123,6 @@ class SAPSuccessFactorsEnterpriseCustomerConfiguration(EnterpriseCustomerPluginC
help_text=_("OAuth client secret.")
)

decrypted_secret = models.CharField(
max_length=255,
blank=True,
default='',
verbose_name="Encrypted Client Secret",
help_text=_(
"The encrypted OAuth client secret."
" It will be encrypted when stored in the database."
),
null=True
)

user_type = models.CharField(
max_length=20,
choices=USER_TYPE_CHOICES,
Expand Down

0 comments on commit d255e40

Please sign in to comment.