fix: change base class for JwtAuthenticationError

[syedsajjadkazmii]

Description:

Issue: When JwtAuthentication class raises JwtUserEmailMismatchError custom exception, it is not identified by the default exception handler of rest framework, therefore, returns response = None and hence we get 500 Server error.

Fix: This PR handles this issue by subclassing JwtAuthenticationError from the AuthenticationFailed exception which is a known exception and will be handled by the default exception handler.

JIRA:

VAN-1694

Additional Details

• Dependencies:: List dependencies on other outstanding PRs, issues, etc.
• Merge deadline: List merge deadline (if any)
• Testing instructions: Provide non-trivial testing instructions
• Author concerns: List any concerns about this PR

Reviewers:

• tag reviewer

Merge checklist:

• All reviewers approved
• CI build is green
• Version bump if needed
• Changelog record added
• Documentation updated (not only docstrings)
• Commits are squashed

Post merge:

• Create a tag
• Check new version is pushed to PyPi after tag-triggered build is
  finished.
• Delete working branch (if not needed anymore)

[syedsajjadkazmii]

Hi @robrap, could i please get your review here?

[robrap]

1. Could we change the base class instead?

class JwtAuthenticationError(exceptions.AuthenticationFailed):

2. Is there any additional assertion we could add to a test to ensure that the right type of exception is being used?

[syedsajjadkazmii]

Could we change the base class instead?

Yes, done.

Is there any additional assertion we could add to a test to ensure that the right type of exception is being used?

Since AuthenticationFailed is a known exception to the default exception handler therefore it gets handled by the exception handler and we only get a 401 Unauthorized response. Exception is not being propagated up and we are not getting it in the test. So, I don't think we can assert the exception type.

[robrap]

Although it is unlikely that someone will break this, a unit test that creates an instance of JwtSessionUserMismatchError and asserts that it is also an instance of AuthenticationFailed would prevent regressions. I'm not sure if it is worth it, but it is also very quick to implement. I'll leave it to you to decide.

[robrap]

I left a unit test idea, but I'll leave that to you to decide. See #433 (comment). Thanks.

[syedsajjadkazmii]

I left a unit test idea, but I'll leave that to you to decide. See #433 (comment). Thanks.

Thanks, I have added the test