Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ENABLE_COURSE_DISCOVERY_DEFAULT_LANGUAGE_FILTER flag #2210

Closed
wants to merge 1 commit into from

Conversation

navinkarkera
Copy link
Contributor

@navinkarkera navinkarkera commented Nov 13, 2023

openedx/edx-platform#33647

Reviewers

Possible roles follow. The PR submitter checks the boxes after each reviewer finishes and gives 👍.

  • Subject matter expert:
  • Subject matter expert:
  • Product review:
  • Partner support:
  • PM review:

FYI: Tag anyone else who might be interested in this PR here.

Testing

  • Ran ./run_tests.sh without warnings or errors

HTML Version (optional)

  • Build an RTD draft for your branch and add a link here

Sandbox (optional)

  • Point to or build a sandbox for the software change and add a link here

Post-review

  • Add a comment with the description of this change or link this PR to the next release notes task.
  • Squash commits

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 13, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211
Copy link

Hi @navinkarkera - is this ready for review?

@mphilbrick211
Copy link

@openedx/axim-engineering I think this is all set.

@feanil
Copy link
Contributor

feanil commented Jan 17, 2024

It looks like this is blocked on the code PR openedx/edx-platform#33647 landing. We shouldn't merge this until after that has merged.

@farhaanbukhsh
Copy link
Member

@feanil The PRs are merged :)

@navinkarkera
Copy link
Contributor Author

Closing, deemed unnecessary. See this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants