-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding VBox and Vagrant max versions #1356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I did find https://openedx.atlassian.net/browse/OPEN-1658 , was that the problem you hit? If so, it may be worth referencing the ticket here
@jmbowman Ah nice, added to the PR and I'll comment on the issue referencing back here. |
@bmedx are you sure Vagrant 1.8.7 doesn't work? I know 1.8.5 didn't, but thought that .7 had a fix. |
@nedbat I had tested it both ways, but just re-ran with 1.8.7 and it worked. I don't have the logs around to see what happened, unfortunately, perhaps it was some other transient error. Vagrant changelogs don't seem to mention the issue I was seeing, which had to do with libcurl versioning, so I can't identify which version(s) may have been broken. Aside from 1.8.5 do you know of any others? I'll update this change tomorrow to be more accurate. |
@bmedx OK, the libcurl problem is known in 1.8.7, and we've been solving it manually: hashicorp/vagrant#7997 . These guys went so far as to add a warning to their Vagrantfile: zulip/zulip@287eb2c |
@nedbat Are you suggesting we add that information to the docs? I'm not sure what the right level of detail to go for there is. |
Honestly, I'm not sure what the right recommendations are. I don't know what problems people have had with Virtualbox 5.1. I know I had a problem the other day that was only solved by upgrading to 5.1, so it all feels really really squishy and I hate it :) |
@nedbat have you been able to confirm the supported versions? |
I imagine that with the move to Docker this is no longer relevant, or at least won't be soon. I'm going to close it out. |
Ran into some issues with setting up devstack on the most recent Vagrant and VirtualBox versions. Looks like they are known issues, so just updating the docs to clarify working versions of those requirements.
[OPEN-1658] (https://openedx.atlassian.net/browse/OPEN-1658)
Reviewers
Testing
Post-review