Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add default value while getting content type header #416

Merged
merged 2 commits into from
May 22, 2024
Merged

fix: add default value while getting content type header #416

merged 2 commits into from
May 22, 2024

Conversation

iamsobanjaved
Copy link
Contributor

@iamsobanjaved iamsobanjaved commented May 22, 2024 •
edited
Loading

Description:

  • Add default value while getting content-type header to avoid KeyError.

Reviewers:

  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPi after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns:

List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

@iamsobanjaved iamsobanjaved mentioned this pull request May 22, 2024
Merged
3 tasks
@iamsobanjaved iamsobanjaved merged commit 964b3c0 into master May 22, 2024
11 checks passed
@iamsobanjaved iamsobanjaved deleted the iamsobanjaved/dd-rum-middleware-fix branch May 22, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdullahwaheed abdullahwaheed abdullahwaheed approved these changes

@mumarkhan999 mumarkhan999 mumarkhan999 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamsobanjaved @abdullahwaheed @mumarkhan999