feat: remove waffle forced ccached miss switch #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumarkhan999
force-pushed
the
umar/remove-waffle-forced-cached-miss-switch
branch
2 times, most recently
from
06d7cef to
92e4041
Compare
iamsobanjaved
approved these changes
Nov 27, 2023
mumarkhan999
force-pushed
the
umar/remove-waffle-forced-cached-miss-switch
branch
from
92e4041 to
5424810
Compare
mumarkhan999
deleted the
umar/remove-waffle-forced-cached-miss-switch
branch
|
@mumarkhan999: This toggle duplicated a legacy bug, right? Does that mean the bug no longer exists? It would be great if you could leave a quick note about why we no longer need the toggle. Thanks. |
|
@robrap Yes. The |
|
@mumarkhan999: Great. Also, I missed the issue link if it was there already. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Description
edx_django_utils.cache.disable_forced_cache_miss_for_nonewaffle switch which was added in version5.7.0version for backward compatibility.5.7.0