fix: standardise requirement files structure in cookiecutter templates #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmc-edx
reviewed
May 31, 2022
timmc-edx
reviewed
May 31, 2022
UsamaSadiq
force-pushed
the
usamasadiq/bom-2133-requirement-files-structure
branch
from
92805ef to
d7d5fdb
Compare
Jawayria
reviewed
Jun 27, 2022
timmc-edx
reviewed
Jul 5, 2022
timmc-edx
approved these changes
Jul 11, 2022
|
Oh, one last thing -- could you add a CHANGELOG.rst entry before merging? Thanks! |
UsamaSadiq
force-pushed
the
usamasadiq/bom-2133-requirement-files-structure
branch
from
ba57a39 to
4bf2732
Compare
timmc-edx
added a commit
to openedx/event-bus-kafka
that referenced
this pull request
Jul 13, 2022
- openedx/edx-cookiecutters#199 -- requirements - openedx/edx-cookiecutters#216 -- tox
2 tasks
timmc-edx
added a commit
to openedx/event-bus-kafka
that referenced
this pull request
Jul 18, 2022
Implement `send_to_event_bus`, accepting signal, data, topic, and key information. - Addresses #5 - Core talk-to-Kafka parts were copied from license manager prototype work, including https://github.com/openedx/license-manager/blob/38b38b0979bb5f643595337a9c189f619a7d483b/license_manager/apps/subscriptions/event_bus_utils.py#L56 - Manually tested against devstack Kafka (instructions included in commit) - Punting on caching the producer for now, but do at least cache the serializer Also: - Remove deprecated config line - Include some recent improvements from cookiecutter: - openedx/edx-cookiecutters#199 (requirements) - openedx/edx-cookiecutters#216 (test-all) Small improvements that should be upstreamed to the cookiecutter: - Clean up after docs build and before test-all - Ignore pii_report output dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: BOM-2133
Description