test: two small tweaks to the tests #376
Conversation
nedbat
force-pushed
the
nedbat/small-tweaks
branch
from
cf42392
to
c49cc73
Compare
It's returning configuration, so the places that need the configuration can get it directly instead of having options_baked return it.
nedbat
force-pushed
the
nedbat/small-tweaks
branch
from
c49cc73
to
995d26a
Compare
| @@ -32,7 +32,7 @@ | |||
| "author_email": "cookie@monster.org", | |||
| "author_name": "Cookie Monster", | |||
| "library_name": "cookie_lover", | |||
| "github_org": "bakery_org", | |||
| "github_org": "openedx", | |||
There was a problem hiding this comment.
I infer that you've made this change to test the new branch, and that the other cookiecutter tests use non-openedx orgs?
There was a problem hiding this comment.
Yes, this was to have a mixture of organizations across all of the tests.
|
What prompted the changes to the hardcoding test? |
|
@timmc-edx Are you still waiting on something from me? |
|
Yeah, not sure if you saw this comment:
I'm wondering what the failure mode was that prompted this (whether observed or hypothetical). |
|
If you mean counting the right and wrong lines, I was curious about how many lines there were, and figured there should be something more than "no bad lines." There should also be some good lines. |
|
Got it, makes sense. |
I keep finding small improvements, I hope the stream of PRs isn't a nuisance.
Merge checklist:
Check off if complete or not applicable: