-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: two small tweaks to the tests #376
Conversation
cf42392
to
c49cc73
Compare
It's returning configuration, so the places that need the configuration can get it directly instead of having options_baked return it.
c49cc73
to
995d26a
Compare
@@ -32,7 +32,7 @@ | |||
"author_email": "cookie@monster.org", | |||
"author_name": "Cookie Monster", | |||
"library_name": "cookie_lover", | |||
"github_org": "bakery_org", | |||
"github_org": "openedx", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I infer that you've made this change to test the new branch, and that the other cookiecutter tests use non-openedx orgs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this was to have a mixture of organizations across all of the tests.
What prompted the changes to the hardcoding test? |
@timmc-edx Are you still waiting on something from me? |
Yeah, not sure if you saw this comment:
I'm wondering what the failure mode was that prompted this (whether observed or hypothetical). |
If you mean counting the right and wrong lines, I was curious about how many lines there were, and figured there should be something more than "no bad lines." There should also be some good lines. |
Got it, makes sense. |
I keep finding small improvements, I hope the stream of PRs isn't a nuisance.
Merge checklist:
Check off if complete or not applicable: