-
Notifications
You must be signed in to change notification settings - Fork 23
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test(refactor): no need for options_baked to return another fixure
It's returning configuration, so the places that need the configuration can get it directly instead of having options_baked return it.
- Loading branch information
Ned Batchelder
committed
Aug 7, 2023
1 parent
104a905
commit c49cc73
Showing
3 changed files
with
7 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -17,10 +17,10 @@ | |||||
from .venv import all_files | ||||||
|
||||||
|
||||||
def test_github_org_is_right(options_baked): | ||||||
def test_github_org_is_right(options_baked, configuration): # pylint: disable=unused-argument | ||||||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
nedbat
Contributor
|
# Fixture names aren't always used in test functions. Disable completely. | |
# pylint: disable=unused-argument |
I guess that's a better way to approach it here too. This file is a file full of tests. I'll change it.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hmm. Why did pylint complain about this, but not about the unused
options_baked
intest_models
?