-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jswope00/migrate olx docs #819
Conversation
Thanks for the pull request, @jswope00! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@jswope00 - is there a corresponding PR to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added corrections to the README since that's not under the "Migrate me" section. Looks good to go for a first migration pass.
source/educators/how-tos/course_development/exercise_tools/embed_google_calendar.rst
Outdated
Show resolved
Hide resolved
https://github.com/openedx/edx-documentation/tree/master/en_us/olx/source | ||
|
||
The edX documentation team welcomes contributions from Open edX community | ||
members. You can find guidelines for how to `contribute to edX Documentation`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this a reference to https://github.com/openedx/docs.openedx.org/edit/main/source/documentors/references/doc_guidelines.rst ? (It doesn't have a ref tag on it currently)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, added a ref tag and pointed to that ref tag in this commit: jswope00@15ae716
@@ -49,7 +49,7 @@ also enables Google Drive files. | |||
... | |||
</course> | |||
|
|||
For more information, see `OLX Course Building Blocks`_ in the | |||
For more information, see :ref:`OLX Course Building Blocks` in the | |||
*EdX Open Learning XML Guide*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could probably do a find-replace for this to "Open edX Open Learning"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jswope00 if you can address my comments and merge this, I'll update the old docs site to point at the new location ✅ |
Co-authored-by: Sarina Canelake <sarina@axim.org>
…00/docs.openedx.org into jswope00/migrate_olx_docs
Migrate the OLX docs from ReadtheDocs into docs.openedx.org.
This pull will consist of several commits for the different stages of migration