-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to use two arm arch #411
Conversation
Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #411 +/- ##
=======================================
Coverage 96.12% 96.12%
=======================================
Files 58 58
Lines 4568 4568
=======================================
Hits 4391 4391
Misses 177 177 ☔ View full report in Codecov by Sentry. |
Hi @ghassanmas, thanks for your contribution! Is it ready for review? |
Yes, it is. :) |
label: core contributor |
@ghassanmas OK, great :) @asadazam93 This PR is ready for review by Infinity. |
Hi @asadazam93, a friendly ping about my previous comment. Do you have any updates on when this PR could be lined up for engineering review? |
@ghassanmas can you please rebase? |
44fe795
to
36e9e3a
Compare
@asadazam93 done. Self note, add to |
@ghassanmas some checks are failing, can you please fix those? |
I don't think the test fail is releavnt, I will to ammend commit to rerun tests, I only cahnged Ruby 3 lockfile, it shouldn't at all affect ruby 2 tests. |
36e9e3a
to
16ae75f
Compare
@asadazam93 the failing tests is related to CodeCov which is not uncommon, it fails to upload report or something, thus I don't thing its related to the code |
This repo depends on codecov 0.6.0 and here which has been depreacted for over a year
|
@asadazam93 Also the logs complain that code cov token doesn't exits github env. |
Installing the bundle on arm based arch fails for deployment it exit while complaining that platform doesn't exist gem lock file, and suggest to add it by: `bundle lock --add-platform aarch64-linux` Fixes: overhangio/tutor-forum/issues/23
16ae75f
to
e14c1d6
Compare
@asadazam93 it passed, and as expected without doing any thing beside amending the commmit. Something not right about those tests. In any case this is already deployed live/production the ARM image at https://lms.zaat.dev you can use laerner-ar@zaat.dev identified by 'zaatdemo' @ https://apps.lms.zaat.dev/discussions/course-v1:zaatdev+OX101+2023_4 |
@ghassanmas 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This commits closes #23 Related upsream PR openedx/cs_comments_service/pull/411
This commits closes #23 Related upsream PR openedx/cs_comments_service/pull/411
Installing the bundle on arm based arch fails for deployment
it exit while complaining that platform doesn't exist gem lock
file, and suggest to add it by:
bundle lock --add-platform aarch64-linux
Fixes: overhangio/tutor-forum/issues/23