Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add badges feature #2489

Merged
merged 25 commits into from
Jul 22, 2024
Merged

feat: add badges feature #2489

Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
f28bf31
feat: add badges feature
kyrylo-kh May 24, 2024
143fd9b
chore: update dummy translations
kyrylo-kh May 27, 2024
09ecff8
fix: merge conflicted migrations
kyrylo-kh May 27, 2024
58fa7b8
test: fix penalties tests
kyrylo-kh May 27, 2024
6fd2782
test: fix tests for credentials api
kyrylo-kh May 27, 2024
3366597
style: fix imports order
kyrylo-kh May 27, 2024
8613e01
style: format code
kyrylo-kh May 27, 2024
8a727be
test: increase test coverage
May 30, 2024
8c47751
chore: update requirements
andrii-hantkovskyi Jun 3, 2024
ed10d9b
refactor: squash migrations + text cleanup + resolve conflict
Jun 11, 2024
9aac1cd
chore: resolve merge conflict
andrii-hantkovskyi Jun 11, 2024
e09dd7c
refactor: clean up + requirement update
Jun 12, 2024
7526a42
docs: documentation update
Jun 14, 2024
2da4037
chore: requirements update
Jun 14, 2024
ecdeef0
chore: merge conflict resolution
andrii-hantkovskyi Jun 14, 2024
79a447d
docs: polishing
Jun 17, 2024
890c799
test: add tests for issuers, api_cliend and commands
kyrylo-kh Jul 2, 2024
31da465
refactor: code cleanup & docs rewording (#180)
andrii-hantkovskyi Jul 5, 2024
7b75760
feat: [ACI-1031] Upgrade requirements to upstream version (#181)
KyryloKireiev Jul 16, 2024
a4f06e4
fix: [ACI-1031] Upgrade requirements
KyryloKireiev Jul 19, 2024
23052ed
fix: [ACI-1031] Resolve migrations conflict
KyryloKireiev Jul 16, 2024
26e56ff
style: [ACI-1031] Try to fix linters
KyryloKireiev Jul 16, 2024
dea54f2
style: [ACI-1031] Try to fix linters v2
KyryloKireiev Jul 16, 2024
748a02c
Merge remote-tracking branch 'EDX/master' into aci.upstream
wowkalucky Jul 19, 2024
6e8944c
fix: regenerate requirements with python 3.8
wowkalucky Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .annotation_safe_list.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,22 @@ auth.Group:
".. no_pii:": "This model has no PII"
auth.Permission:
".. no_pii:": "This model has no PII"
badges.BadgePenalty:
".. no_pii:": "This model has no PII"
badges.BadgeProgress:
".. pii": "Username"
".. pii_types": other
Copy link
Contributor

@justinhynes justinhynes Jun 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: If I understand the markup correctly, the "pii_type" here should be username , with pii being a description (and somewhat redundant".

The pii_type's referenced in OEP-30 are...

- name (used for any part of the user’s name)
- username
- password
- location (used for any part of any type address or country stored)
- phone_number (used for phone or fax numbers)
- email_address
- birth_date (used for any part of a stored birth date)
- ip (IP address)
- external_service (used for external service ids or links such as social media links or usernames, website links, etc)
- biography (any type of free-form biography field)
- gender
- sex
- image
- video
- other (any identifying information not covered by other types, should be specified in the pii annotation)

".. pii_retirement": retained
Copy link
Contributor

@justinhynes justinhynes Jun 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intent to retain this info for credential verification after a learner potentially deletes their account?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users' retirement aspect was completely out of focus during the scope development.
But, we should treat badges as other user credentials (so the same approach as for certificates should fit).
Not implemented though.

badges.BadgeRequirement:
".. no_pii:": "This model has no PII"
badges.CredlyOrganization:
".. no_pii:": "This model has no PII"
badges.DataRule:
".. no_pii:": "This model has no PII"
badges.Fulfillment:
".. no_pii:": "This model has no PII"
badges.PenaltyDataRule:
".. no_pii:": "This model has no PII"
credentials.HistoricalProgramCompletionEmailConfiguration:
".. no_pii:": "This model has no PII"
contenttypes.ContentType:
Expand Down
Empty file added credentials/apps/badges/__init__.py
View file
Open in desktop
Empty file.
Loading