Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade Python version in Dockerfile #2474

Merged
merged 1 commit into from
May 8, 2024

Conversation

justinhynes
Copy link
Contributor

This PR will upgrade the version of Python used in docker images created from the public repos Dockerfile.

Upgrading the Python version is part of the changes for the Redwood release of Open edX.

Run JavaScript tests locally with Karma

There is work being done on a fix to get Karma to run in CI. Until then, however, contributors are required to run these tests locally.

  • Make sure you are inside the devstack container
  • Run make test-karma
  • All tests pass

This PR will upgrade the version of Python used in docker images created from the public repos Dockerfile.

Upgrading the Python version is part of the changes for the Redwood release of Open edX.
@justinhynes justinhynes requested a review from a team as a code owner May 8, 2024 18:05
@justinhynes
Copy link
Contributor Author

justinhynes commented May 8, 2024

I tested this by building an image from the Dockerfile locally and ensuring it built cleanly. Afterwards I updated my docker-compose file in Devstack to use the locally built image, verifying that the default Python version was Python 3.11.9.

We will do additional testing of Credentials functionality on an internal deployment environment.

@justinhynes justinhynes merged commit 5b01df1 into master May 8, 2024
11 checks passed
@justinhynes justinhynes deleted the jhynes/APER-3419_update-Dockerfile-Python-3-11 branch May 8, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants