Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds a test for missing program cert record #2155

Conversation

deborahgu
Copy link
Member

@deborahgu deborahgu commented Aug 31, 2023

  • switch away from logger.exception (which was logging the noisy stacktrace as well as the log message) to logger.debug (because this is expected behavior and we don't want to see messages about it under normal conditions)
  • Adding a test to verify

FIXES: APER-718

Run JavaScript tests locally with Karma

There is work being done on a fix to get Karma to run in CI. Until then, however, contributors are required to run these tests locally.

  • Make sure you are inside the devstack container
  • Run make test-karma
  • All tests pass

* The test verifies the behavior should be acting correctly and not raising exceptions

FIXES: APER-718
@deborahgu deborahgu marked this pull request as draft August 31, 2023 20:27
* To verify that the test is catching the right thing, check the actual log message

FIXES: APER-718
* Switching to debug

FIXES: APER-718
@deborahgu deborahgu marked this pull request as ready for review August 31, 2023 21:16
@deborahgu deborahgu merged commit f236adb into master Sep 1, 2023
9 checks passed
@deborahgu deborahgu deleted the dkaplan1/APER-718_program-cert-record-does-not-exist-errors-in-log branch September 1, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants