fix!: use TinyMCE 5 as HTML editor #207
Conversation
|
Thanks for the pull request, @Agrendalath! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
| menubar: false, | ||
| statusbar: false, | ||
| toolbar_items_size: 'small', | ||
| toolbar: "formatselect | styleselect | bold italic underline forecolor wrapAsCode | bullist numlist outdent indent blockquote | link unlink | code", |
There was a problem hiding this comment.
wrapAsCode is a custom button, which is defined directly in edx-platform. Since it has not been working before, we can remove it.
| height: '200px', | ||
| formats: { code: { inline: 'code' } }, | ||
| codemirror: { path: "" + baseUrl + "/js/vendor" }, | ||
| convert_urls: false, | ||
| plugins: "link codemirror", | ||
| plugins: "lists, link, codemirror", |
There was a problem hiding this comment.
bullist and numlist need the lists plugin.
|
@bradenmacdonald, I found this issue while working on mitodl/edx-sga#339. Since the fix is trivial, I just opened this PR. Would you like to review it? |
|
@Agrendalath Thanks! I can review it, yep. Not sure if I'll get to it today though. |
We removed TinyMCE 4 from the platform last year. BREAKING CHANGE: This is incompatible with Nutmeg.
Agrendalath
force-pushed
the
agrendalath/fix_tinymce_editor
branch
from
9895be3
to
5ad7bb5
Compare
|
@bradenmacdonald, would you mind merging and releasing this? |
|
@Agrendalath 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
@Agrendalath Sure, done. |
Description
We removed TinyMCE 4 from the platform last year. The editor changes are similar to openedx/edx-ora2#1869.
Testing instructions
Author's notes
BREAKING CHANGE: This is incompatible with Nutmeg.